Default to Interpreter, Analysis::AST, Execution::Errors and Pagination::Connections#3145
Merged
Default to Interpreter, Analysis::AST, Execution::Errors and Pagination::Connections#3145
Conversation
Fix Backtrace on Interpreter
Set intepreter current_... values in Query context
rmosolgo
commented
Sep 10, 2020
| when :multiplex | ||
| graphql_multiplex(data[key]) | ||
| when :path | ||
| [key, data[key].join(".")] |
Owner
Author
There was a problem hiding this comment.
I wonder if this ever worked on the interpreter. It was returning [:path, []], and [] was flattened out of existence by the .flatten(2) call below, then .each_slice(2) raised an error about getting an odd-length array.
rmosolgo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These modules have been in development for a long time, and the recommended approach for a long time. Let's make them the default.
Technically, it's still possible to choose the old behaviors:
But this PR decreases test coverage for those, and 1.12 will also deprecate them with warnings.
Also,
Schema.from_definitionno longer accepts aninterpreter:option; it is alwaysinterpreter: true.