Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the only solution here is to implement these in application logic. That works fine, but we could provide a framework to help with it.
Fixes #799
Fixes #3164
To figure out in this PR:
validates(...)on a field, using a custom validator. It could be better, like Rails, but I think it's good enough for now.validates:orvalidates ...default_value:"count" inrequired: { one_of: ... }combinations?.graphql_nameor.pathin error messages?Should this work include "static" validations? (This implementation takes effect at runtime, which is the easiest and most flexible. But some validations could be run ahead-of-time.)no, we can refine this later.