track deprecated arguments alongside deprecated fields#3549
Merged
rmosolgo merged 3 commits intormosolgo:masterfrom Aug 9, 2021
anujbiyani:analyze-deprecated-arguments
Merged
track deprecated arguments alongside deprecated fields#3549rmosolgo merged 3 commits intormosolgo:masterfrom anujbiyani:analyze-deprecated-arguments
rmosolgo merged 3 commits intormosolgo:masterfrom
anujbiyani:analyze-deprecated-arguments
Conversation
anujbiyani
commented
Jul 7, 2021
Comment on lines
+39
to
+45
| if argument.definition.type.kind.input_object? | ||
| extract_deprecated_arguments(argument.value.arguments.argument_values) | ||
| elsif argument.definition.type.list? | ||
| argument.value.each { |value| extract_deprecated_arguments(value.arguments.argument_values) } | ||
| end |
Contributor
Author
There was a problem hiding this comment.
I'm not really sure if this is the best way to recurse through input objects. Do you have a better suggestion?
anujbiyani
commented
Jul 7, 2021
Contributor
Author
|
Hey @rmosolgo, would you be able to take a look at this? |
rmosolgo
reviewed
Aug 9, 2021
Owner
rmosolgo
left a comment
rmosolgo
left a comment
There was a problem hiding this comment.
Thanks for the ping! I took a look before but I see I failed to submit my review -- it was sitting here "pending." Sorry about that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tracking for deprecated arguments. I didn't add tracking for all arguments as my app doesn't need it, but happy to add that if you prefer!