Skip to content

Conversation

@rmosolgo
Copy link
Owner

I'm tired of always seeing failed builds, and it seems like this is the flakiest one. Either Rails master is failing (as it did for a while when Rails generators wouldn't generate for HEAD, even when the invoked rails ... command was from HEAD) or TruffleRuby is failing (as it is currently because it's looking up require "digest" wrong, or something like that: truffleruby/truffleruby#2511).

If anyone wants to re-add a passing TruffleRuby build to this project (not truffleruby-head, not rails master), I'll try maintaining it again, but sheesh...

cc @gogainda, in case you'd rather get this build passing somehow ... (I can't figure out how to do it!)

@gogainda
Copy link
Contributor

Would you consider creating an issue in the truffleruby repository?

@rmosolgo
Copy link
Owner Author

Isn't truffleruby/truffleruby#2511 the issue for what's failing?

@gogainda
Copy link
Contributor

Created a new issue for truffleruby

@rmosolgo rmosolgo merged commit ce99775 into master Jan 20, 2022
@rmosolgo rmosolgo deleted the remove-truffle-build branch January 20, 2022 12:49
@bjfish
Copy link

bjfish commented Jan 20, 2022

This CI failure is tracked by the TruffleRuby team since it started happening. There is a TruffleRuby PR in progress to implement keyword argument handling to make this implementation pass:

I think it's unfortunate that Github Actions does not support something like continue on failure which is a suggested feature here: actions/runner#2347

I'll propose re-adding this to CI once the specs are all passing.

@rmosolgo
Copy link
Owner Author

Yes, I'd definitely welcome a passing CI build!

@eregon
Copy link

eregon commented Jan 21, 2022

As a quick note the delegation code mentioned above could use ruby2_keywords, that would avoid code duplication, work on all Ruby version and TruffleRuby, and as a bonus is also faster on CRuby >= 3 than the current code.

@eregon
Copy link

eregon commented Jan 21, 2022

@bjfish Maybe you can make a PR with that change once the digest fix is merged?

Probably we should test TruffleRuby on a rails release, not rails master to avoid more unstability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants