Ruby 2.4 is deprecating Bignum and Fixnum#557
Closed
daemonsy wants to merge 1 commit intormosolgo:masterfrom
daemonsy:master
Closed
Ruby 2.4 is deprecating Bignum and Fixnum#557daemonsy wants to merge 1 commit intormosolgo:masterfrom daemonsy:master
daemonsy wants to merge 1 commit intormosolgo:masterfrom
daemonsy:master
Conversation
https://bugs.ruby-lang.org/issues/12005 - Getting deprecation warnings: `/app/vendor/bundle/ruby/2.4.0/gems/graphql-1.4.4/lib/graphql/id_type.rb:9: warning: constant ::Fixnum is deprecated`
Owner
|
Thanks for looking into this! I'm hoping to officially support Ruby 2.4 via #475 but it's been a bit of a struggle getting CI working across all Rubies. Does that branch look like it would cover your needs, too? |
Contributor
Author
|
Ahh, somehow miss that while browsing the PRs. Yes! that looks good, so far we've only seen one deprecation warning pop up. Closing this and seeing if there's anything I can contribute to #475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's up?
Hi, we upgraded an app that uses graphql-ruby to Ruby 2.4 and we're getting a deprecation message on the ID type.
/app/vendor/bundle/ruby/2.4.0/gems/graphql-1.4.4/lib/graphql/id_type.rb:9: warning: constant ::Fixnum is deprecatedhttps://bugs.ruby-lang.org/issues/12005
Missing things:
id_type_spec.rbcovered that pretty well, asserting the coercion of integers, doesn't feel there's a need to write a new case unless you feel otherwisegemspecchange.