Skip far-future date test on 32-bit platforms#46
Closed
nadzyah wants to merge 1 commit into
Closed
Conversation
test_edit_creation_date sets a creation date in the year 3000. On 32-bit platforms time_t is 32-bit and cannot represent dates beyond 2038, so int(datetime.timestamp()) in the machine-readable formatter raises OverflowError. Skip the test where the platform cannot represent such a date
Owner
|
I'm pretty sure I was just being silly when I used the year 3000.
I changed it to 2000 instead, which allows the test to run on all platforms.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_edit_creation_date sets a creation date in the year 3000. On 32-bit platforms time_t is 32-bit and cannot represent dates beyond 2038, so
int(datetime.timestamp())in the machine-readable formatter raises OverflowError. Skip the test where the platform cannot represent such a dateOriginally found while testing the package in Debian on i386 arch:
https://ci.debian.net/packages/t/torf-cli/testing/i386/71579780/