Restore piece_size_min_default in finally block#62
Merged
Conversation
forced_piece_size restores Torrent.piece_size_min_default after the with mock.patch() block. When a test raises, the exception propagates through the with block and the restore line is skipped, leaving piece_size_min_default at the test value for all subsequent tests in the same worker process Move the restore into a try/finally to guarantee it runs regardless of whether an exception propagates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forced_piece_size restores Torrent.piece_size_min_default after the with mock.patch() block. When a test raises, the exception propagates through the with block and the restore line is skipped, leaving piece_size_min_default at the test value for all subsequent tests in the same worker process
Move the restore into a try/finally to guarantee it runs regardless of whether an exception propagates
The error occurred while running CI autopkgtests for the torf package in Debian on amd64 and arm64 arches