Skip to content

Feat: Legacy offline manager#3145

Merged
mfazekas merged 13 commits intornmapbox:mainfrom
orca-io:feat/offline-manager-legacy
Dec 6, 2023
Merged

Feat: Legacy offline manager#3145
mfazekas merged 13 commits intornmapbox:mainfrom
orca-io:feat/offline-manager-legacy

Conversation

@orca-nazar
Copy link
Contributor

@orca-nazar orca-nazar commented Oct 27, 2023

Description

Added Legacy Offline Manager module based on this discussion.

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I updated the documentation with running yarn generate in the root folder
  • I added/updated a sample - if a new feature was implemented (/example)

@mfazekas
Copy link
Contributor

@orca-nazar thanks much, I have concerns about doing it as.a build variant.

  • We have enough variants V11 and fabric, we should only add more variants only if realy-really necessary
  • JS interface will of Legacy and regular is the same. So if we change the js interface we should be careful not to affect on or the other.

So I'd prefer a duplicating the JS code and having 2 component instead of conditions compilation.

What do you think?

@orca-nazar
Copy link
Contributor Author

@mfazekas Good points. I will create offlineManagerLegacy.ts and OfflinePacksLegacy.ts as both of them will depend on the native module. Not sure about a sample in Example app and documentation. Do you think it would be good to duplicate it as well?

@orca-nazar
Copy link
Contributor Author

@mfazekas Hey, updated PR with the new JS class for Legacy manager. It misses packs subscriptions functionality. If someone requests, I will add them as well

@orca-nazar orca-nazar force-pushed the feat/offline-manager-legacy branch from e4bcdc8 to 099de8a Compare November 16, 2023 09:54
@mfazekas
Copy link
Contributor

@orca-nazar looks good to me, can you look into the CI?

@orca-nazar orca-nazar force-pushed the feat/offline-manager-legacy branch from bb294e0 to 63732ba Compare December 5, 2023 15:38
@orca-nazar orca-nazar temporarily deployed to CI with Mapbox Tokens December 5, 2023 15:38 — with GitHub Actions Inactive
@orca-nazar orca-nazar temporarily deployed to CI with Mapbox Tokens December 5, 2023 15:39 — with GitHub Actions Inactive
@orca-nazar orca-nazar temporarily deployed to CI with Mapbox Tokens December 5, 2023 15:39 — with GitHub Actions Inactive
@orca-nazar orca-nazar temporarily deployed to CI with Mapbox Tokens December 5, 2023 15:39 — with GitHub Actions Inactive
@orca-nazar orca-nazar temporarily deployed to CI with Mapbox Tokens December 5, 2023 15:39 — with GitHub Actions Inactive
@orca-nazar orca-nazar temporarily deployed to CI with Mapbox Tokens December 5, 2023 15:39 — with GitHub Actions Inactive
@orca-nazar
Copy link
Contributor Author

@orca-nazar looks good to me, can you look into the CI?

@mfazekas So to trigger CI, I need to get your approval. I think I fixed it

@mfazekas mfazekas merged commit 721de19 into rnmapbox:main Dec 6, 2023
@orca-nazar orca-nazar deleted the feat/offline-manager-legacy branch May 14, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants