Conversation
|
@orca-nazar thanks much, I have concerns about doing it as.a build variant.
So I'd prefer a duplicating the JS code and having 2 component instead of conditions compilation. What do you think? |
|
@mfazekas Good points. I will create offlineManagerLegacy.ts and OfflinePacksLegacy.ts as both of them will depend on the native module. Not sure about a sample in Example app and documentation. Do you think it would be good to duplicate it as well? |
|
@mfazekas Hey, updated PR with the new JS class for Legacy manager. It misses packs subscriptions functionality. If someone requests, I will add them as well |
e4bcdc8 to
099de8a
Compare
|
@orca-nazar looks good to me, can you look into the CI? |
bb294e0 to
63732ba
Compare
@mfazekas So to trigger CI, I need to get your approval. I think I fixed it |
Description
Added Legacy Offline Manager module based on this discussion.
Checklist
yarn generatein the root folder/example)