Skip to content

Fix android build issue#3176

Merged
mfazekas merged 1 commit intornmapbox:mainfrom
lineinspector:fix-android-build-error
Nov 17, 2023
Merged

Fix android build issue#3176
mfazekas merged 1 commit intornmapbox:mainfrom
lineinspector:fix-android-build-error

Conversation

@andrei-tofan
Copy link
Contributor

@andrei-tofan andrei-tofan commented Nov 15, 2023

Description

Fixes #3175

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I updated the documentation with running yarn generate in the root folder
  • I added/updated a sample - if a new feature was implemented (/example)

@mfazekas
Copy link
Contributor

@andrei-tofan what is your RN version?!

This was removed in order to support RN 0.73, see:
react-native-community/discussions-and-proposals#671 (comment)

@andrei-tofan
Copy link
Contributor Author

I'm on RN 0.68.7, will the support be dropped for RN > 0.73?

@mfazekas
Copy link
Contributor

@andrei-tofan yes we'll drop 0.68 if we cannot support both 0.68 and 0.73. But reading the comments we might be able to add that namespace back - it just will warning on 0.73. I'll upgrade example, and we'll see that.

@mfazekas mfazekas reopened this Nov 17, 2023
@mfazekas mfazekas merged commit 70bf7e5 into rnmapbox:main Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Build fails because of missing package attribute

2 participants