ci-for-fored-repos renamed and removed extra environment key#3213
Closed
MichaelDanielTom wants to merge 1 commit intornmapbox:mainfrom
Closed
Conversation
Contributor
|
@MichaelDanielTom Thanks much for noting the typo. We need the environment, for the approval process and also the secrets used in this ci lives in the environment. I've opened another pr fixing the key and name of the ci file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After pushing to a fork of @rnmapbox/maps, the Github Action fails with:
Wasn't sure if the misspelled key in the yaml was supposed to be there or not (even if correctly spelled) so removed it - sorry if it was meant to be there for some other functionality and will close this pr if so!
Also renamed file assuming it's supposed to be
ci-for-forked-repos