Fix crash setting zoomEnabled on MapView creation

[davegurnell]

Description

Fixes a bug where, in iOS, setting the zoomEnabled prop on MapView before the native component is created would cause a crash.

The code change is minimal and I've tested it in my own app. I'm having trouble getting a test case into the example app, though. Help with that would be appreciated. I'm on macOS Sonoma and I'm using Xcode 15.1.

Checklist

• I've read CONTRIBUTING.md
• I updated the doc/other generated code with running yarn generate in the root folder
• I have tested the new feature on /example app.
  • In V11 mode/ios
  • In New Architecture mode/ios
  • In V11 mode/android
  • In New Architecture mode/android
• I added/updated a sample - if a new feature was implemented (/example)

I'm afraid I'm unable to get the example app to build. I've done the following:

• Change to the repo root directory
• Run yarn generate and yarn build
• Change to the example directory and run yarn install
• Change to the example/ios directory and runpod install --repo-update and pod update MapboxMaps
• Build and run from Xcode (I can't get yarn react-native run-ios working because of some Ruby problem)
• Run yarn start

I get the following error message when I run the app:

[mfazekas]

Thanks this looks good.

FWIW I'm considering deprecating zoomEnabled as we now have finer grain control with getstureSettings

[mfazekas]

Change to the repo root directory
Run yarn generate and yarn build
Change to the example directory and run yarn install
Change to the example/ios directory and runpod install --repo-update and pod update MapboxMaps
Build and run from Xcode (I can't get yarn react-native run-ios working because of some Ruby problem)
Run yarn start

That's interesting...

You do see the @rnmapbox/maps symlink in example/node_modules right?!

example % ls -la node_modules/@rnmapbox/maps 
lrwxr-xr-x@ 1 boga  staff  8 Dec  9 11:50 node_modules/@rnmapbox/maps -> ../../..

[mfazekas]

@davegurnell what is your yarn version?! We might need yarn classic for the example to build

[davegurnell]

That's probably a source of errors. I'm on Yarn 3.x, which can run Yarn 1.x if you configure it correctly. There could be a ticket here to either bump some tool versions or flesh out the docs to help new developers with the existing toolchain. I'll have a tinker over the Christmas break and see if I can get things to work. I'll open a Discussion if I come up with anything useful. Merry Christmas!

…

--- original message --- On December 15, 2023 at 11:02 AM GMT ***@***.*** wrote: @davegurnell what is your yarn version?! We might need yarn classic for the example to build — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***> --- end of original message ---

[mfazekas]

@davegurnell sorry I've overlooked and looked at the wrong node_modules directory. Yarn 3 should work as well.

You do see the @rnmapbox/maps symlink in example/node_modules right?!

example % ls -la node_modules/@rnmapbox/maps 
lrwxr-xr-x@ 1 boga  staff  8 Dec  9 11:50 node_modules/@rnmapbox/maps -> ../../..

[davegurnell]

Oddly, that wasn't the problem but now I think it is.

I'm going around in circles with different versions of node, yarn, ruby, etc.

Don't worry about me - I'll work it all out and if I find anything useful I'll start a Discussion with some proposals for the README.

Thanks for your help and for quick publication of that fix.

Have a great Christmas!