Skip to content

feat: implement MovePointShapeAnimator and ChangeLineOffsetsShapeAnimator#3281

Merged
mfazekas merged 122 commits intornmapbox:mainfrom
TruckMap:truckmap/prod
Feb 23, 2024
Merged

feat: implement MovePointShapeAnimator and ChangeLineOffsetsShapeAnimator#3281
mfazekas merged 122 commits intornmapbox:mainfrom
TruckMap:truckmap/prod

Conversation

@naftalibeder
Copy link
Collaborator

@naftalibeder naftalibeder commented Dec 19, 2023

Description

This implements the specific shape animators for animating a single point source and a line by its offsets.

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Videos

Screen.Recording.2024-01-30.at.2.20.43.PM.mov
Screen.Recording.2024-01-30.at.2.21.10.PM.mov

@naftalibeder naftalibeder marked this pull request as draft December 19, 2023 21:43
Copy link
Contributor

@mfazekas mfazekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naftalibeder thanks much for looking into it. Looks good to me 👍 , some notes in the review!

@naftalibeder
Copy link
Collaborator Author

@mfazekas Changes made. :) What's next?

@mfazekas
Copy link
Contributor

mfazekas commented Feb 5, 2024

@mfazekas Changes made. :) What's next?

Fix CI

@naftalibeder
Copy link
Collaborator Author

@mfazekas Ok seems good to go.

@mfazekas
Copy link
Contributor

mfazekas commented Feb 6, 2024

@mfazekas Ok seems good to go.

There are some errors in iOS builds

@mfazekas
Copy link
Contributor

mfazekas commented Feb 7, 2024

@naftalibeder sorry can you update the PR? The CI was broken and should be fixed now:

@Cdingram can you update your PR, CI was broken and was fixed with this commit 5394b31 so

@naftalibeder
Copy link
Collaborator Author

@mfazekas Any ideas about the CI failures? They seem outside of the scope of what I've worked on in this PR, so I'm not sure what to look into.

@mfazekas
Copy link
Contributor

@mfazekas Any ideas about the CI failures? They seem outside of the scope of what I've worked on in this PR, so I'm not sure what to look into.

I think it's related to issue cocoa pods 1.15.0. I'll add a workaround for this on the main branch.

@naftalibeder
Copy link
Collaborator Author

@mfazekas So what is left on this before you'd be comfortable merging it?

@mfazekas
Copy link
Contributor

@mfazekas So what is left on this before you'd be comfortable merging it?

The biggest issue is that all iOS CI fails. I don't see the error message.

@naftalibeder
Copy link
Collaborator Author

@mfazekas All checks passed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants