feat: implement MovePointShapeAnimator and ChangeLineOffsetsShapeAnimator#3281
feat: implement MovePointShapeAnimator and ChangeLineOffsetsShapeAnimator#3281mfazekas merged 122 commits intornmapbox:mainfrom
MovePointShapeAnimator and ChangeLineOffsetsShapeAnimator#3281Conversation
mfazekas
left a comment
There was a problem hiding this comment.
@naftalibeder thanks much for looking into it. Looks good to me 👍 , some notes in the review!
|
@mfazekas Changes made. :) What's next? |
Fix CI |
|
@mfazekas Ok seems good to go. |
There are some errors in iOS builds |
|
@naftalibeder sorry can you update the PR? The CI was broken and should be fixed now: @Cdingram can you update your PR, CI was broken and was fixed with this commit 5394b31 so |
|
@mfazekas Any ideas about the CI failures? They seem outside of the scope of what I've worked on in this PR, so I'm not sure what to look into. |
I think it's related to issue cocoa pods 1.15.0. I'll add a workaround for this on the main branch. |
|
@mfazekas So what is left on this before you'd be comfortable merging it? |
The biggest issue is that all iOS CI fails. I don't see the error message. |
android/src/main/java/com/rnmapbox/rnmbx/components/AbstractEventEmitter.kt
Outdated
Show resolved
Hide resolved
|
@mfazekas All checks passed :) |
Description
This implements the specific shape animators for animating a single point source and a line by its offsets.
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Videos
Screen.Recording.2024-01-30.at.2.20.43.PM.mov
Screen.Recording.2024-01-30.at.2.21.10.PM.mov