Skip to content

fix(ios): localizeLabels when changing styleURL#3303

Merged
mfazekas merged 2 commits intornmapbox:mainfrom
cixio:localizeLabels
Jan 9, 2024
Merged

fix(ios): localizeLabels when changing styleURL#3303
mfazekas merged 2 commits intornmapbox:mainfrom
cixio:localizeLabels

Conversation

@cixio
Copy link
Contributor

@cixio cixio commented Jan 5, 2024

Description

Fixes #3302

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

@cixio cixio had a problem deploying to CI with Mapbox Tokens January 5, 2024 15:23 — with GitHub Actions Error
@cixio cixio had a problem deploying to CI with Mapbox Tokens January 5, 2024 15:23 — with GitHub Actions Error
@cixio cixio had a problem deploying to CI with Mapbox Tokens January 5, 2024 15:23 — with GitHub Actions Error
@cixio cixio had a problem deploying to CI with Mapbox Tokens January 5, 2024 15:23 — with GitHub Actions Error
@cixio cixio had a problem deploying to CI with Mapbox Tokens January 5, 2024 15:23 — with GitHub Actions Error
@cixio cixio had a problem deploying to CI with Mapbox Tokens January 5, 2024 15:23 — with GitHub Actions Error
@cixio cixio temporarily deployed to CI with Mapbox Tokens January 5, 2024 15:25 — with GitHub Actions Inactive
@cixio cixio temporarily deployed to CI with Mapbox Tokens January 5, 2024 15:25 — with GitHub Actions Inactive
@cixio cixio temporarily deployed to CI with Mapbox Tokens January 5, 2024 15:25 — with GitHub Actions Inactive
@cixio cixio temporarily deployed to CI with Mapbox Tokens January 5, 2024 15:25 — with GitHub Actions Inactive
@cixio cixio temporarily deployed to CI with Mapbox Tokens January 5, 2024 15:25 — with GitHub Actions Inactive
@cixio cixio temporarily deployed to CI with Mapbox Tokens January 5, 2024 15:25 — with GitHub Actions Inactive
@mfazekas mfazekas mentioned this pull request Jan 7, 2024
Closed
@mfazekas mfazekas merged commit f308f35 into rnmapbox:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: iOS: localizeLabels not adopted when changing map style

2 participants

@cixio @mfazekas