feat: make Mapbox SDK authentication optional#4012
Merged
Conversation
• Remove mandatory authentication requirement for Mapbox SDK downloads • Update build.gradle files to make MAPBOX_DOWNLOADS_TOKEN optional • Remove .netrc setup from iOS CI workflow • Make gradle.properties setup optional in Android CI workflow • Update Expo plugin to make authentication optional • Update documentation to reflect optional authentication This change aligns with Mapbox's removal of download token requirements as mentioned in: mapbox/mapbox-maps-flutter#775 The authentication is kept optional for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
• Remove all MAPBOX_DOWNLOAD_TOKEN related steps from Android and iOS CI workflows • Remove download token secrets from workflow definitions • Remove explanatory comments since they're no longer needed • Clean up CI to be simpler since authentication is no longer required 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…steps • Remove complex authentication setup from Android installation guide • Remove authentication setup from iOS installation guide • Add simple note explaining Mapbox removed auth requirement • Simplify maven repo configuration to just URL • Make documentation more user-friendly and easier to follow This reflects the new reality that Mapbox SDK downloads no longer require authentication tokens, making the setup process much simpler for developers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove ENV_MAPBOX_ACCESS_TOKEN and use MAPBOX_ACCESS_TOKEN directly - This matches the secret expected by ci-requiring-tokens workflow - Remove unnecessary ENV_MAPBOX_DOWNLOAD_TOKEN secret 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
mfazekas
force-pushed
the
feat/remove-mapbox-auth-requirement
branch
from
accfac2 to
ce4e9ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
• Remove mandatory authentication requirement for Mapbox SDK downloads
• Align with Mapbox's removal of download token requirements
• Make authentication optional for backward compatibility
Changes
Technical Details
example/android/build.gradleto conditionally set authentication only if token is providedTest plan
References:
🤖 Generated with Claude Code