Skip to content

feat(service): mark GetStatus, GetStatuses, ListServices as NO_SIDE_EFFECTS #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rustatian merged 1 commit into from
May 11, 2026
Merged

feat(service): mark GetStatus, GetStatuses, ListServices as NO_SIDE_EFFECTS #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions roadrunner/api/service/v1/service_rpc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ service ServiceManager {
rpc CreateService(Create) returns (Response);
rpc Terminate(Service) returns (Response);
rpc Restart(Service) returns (Response);
rpc GetStatus(Service) returns (Status);
rpc GetStatuses(Service) returns (Statuses);
rpc ListServices(Service) returns (List);
rpc GetStatus(Service) returns (Status) {
option idempotency_level = NO_SIDE_EFFECTS;
}
rpc GetStatuses(Service) returns (Statuses) {
option idempotency_level = NO_SIDE_EFFECTS;
}
rpc ListServices(Service) returns (List) {
option idempotency_level = NO_SIDE_EFFECTS;
}
}