fix: debug mode streaming #98
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
WalkthroughThe changes primarily focus on enhancing the debug mode functionality in the worker pool. They introduce log messages to indicate when a worker is stopped and when it's running in debug mode, with the latter also triggering worker destruction post-response. Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (2)
- pool/static_pool/debug.go (4 hunks)
- worker/worker.go (1 hunks)
Files skipped from review due to trivial changes (1)
- worker/worker.go
Additional comments (Suppressed): 4
pool/static_pool/debug.go (4)
16-20: The new import statement for the package "github.com/roadrunner-server/sdk/v4/fsm" has been added. Ensure that this package is correctly installed and available in your project dependencies.
17-17: A debug log message has been added to indicate when the code is executing in debug mode, and that the worker will be destroyed after receiving a response. This is a good practice as it provides more visibility into the application's behavior during debugging.
64-69: The stop operation has been updated to include a context with timeout. This is a good practice as it prevents potential blocking of the stop operation if the stream cannot be cancelled immediately. However, ensure that the value of
sp.cfg.StreamTimeoutis appropriately set to prevent premature cancellation.95-104: The worker is now stopped using
w.Stop()instead of being released back to the pool. This change aligns with the debug log message indicating that the worker will be destroyed after a response is received. However, ensure that this change does not lead to resource leaks or other unintended side effects due to workers not being reused.
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 77.82% 77.10% -0.72%
==========================================
Files 23 23
Lines 2070 2088 +18
==========================================
- Hits 1611 1610 -1
- Misses 405 423 +18
- Partials 54 55 +1
|
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.Summary by CodeRabbit
Chore: Enhanced Debugging Information
pool/static_pool/debug.goandworker/worker.go. These changes provide better visibility into the worker lifecycle, specifically when a worker is stopped or destroyed.