Skip to content

Conversation

@gzagura
Copy link
Contributor

@gzagura gzagura commented Feb 19, 2020

No description provided.

@rob-balfre
Copy link
Owner

@gzagura usually components inherit font-family from body or a parent element. If we add this change it will override everyones placeholder font to 'serif' unless they specify placeholderFontFamily.

@gzagura
Copy link
Contributor Author

gzagura commented Feb 20, 2020

@rob-balfre yeah, didn't think about that, now it's better.

@rob-balfre
Copy link
Owner

I'm happy to approve this but you know you can just achieve something similar with global css or using Svelte's :global(..) ?

https://svelte.dev/repl/f1c601354a524feb883f73e26d71c80c?version=3.12.1

@gzagura
Copy link
Contributor Author

gzagura commented Feb 26, 2020

@rob-balfre thank you, didn't know that

@rob-balfre rob-balfre closed this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants