feat: add more replaceable components #233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows more fine-grained control over the markup and styling, which, in some cases, may be more preferable than mapping CSS vars or overriding the built-in styles. resolves rob-balfre#231
Owner
|
Thanks @wallw-bits will take some time to go through this, lots to digest and consider. Please just use this branch in your code for now. |
Author
|
Let me know if you get a chance to look at this and I will update any conflicts then. |
|
The change would be awesome! Can we merge it in? |
Owner
|
Cleaning up old PRs before v5 release. Sorry I never really got to this one, my bad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more fine-grained control over the markup and styling, which, in some cases, may be more preferable than mapping CSS vars or overriding the built-in styles.
I added tests for custom component use and examples for integrating with Bootstrap, but it may be worth creating a library which wraps
svelte-selectand provides all that since it is kind of a lot.resolves #231