Skip to content

fix: exit 0 with empty output when no files are provided#16

Merged
robaone merged 1 commit into
mainfrom
fix/handle-empty-file-list
May 4, 2026
Merged

fix: exit 0 with empty output when no files are provided#16
robaone merged 1 commit into
mainfrom
fix/handle-empty-file-list

Conversation

@robaone
Copy link
Copy Markdown
Owner

@robaone robaone commented May 4, 2026

Problem

When a PR only deletes files, tj-actions/changed-files returns nothing in all_changed_files (deletions are excluded by default). This produces empty input to parse_file_list_for_projects.sh, which was exiting with code 1.

Fix

Changed the empty-input guard to exit 0 — no files to process means no projects to build, which is valid (not an error).

Reproducer

PR robaone/source#323 fails because it only deletes projects/ai-prompts/claude/skills/swan-peer-review-needs-review/SKILL.md.

A PR that only deletes files produces no entries in all_changed_files,
resulting in empty input. This is a valid state — treat it as no
projects to build rather than an error.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1a960415-1637-4b6f-9b51-f50be579b5c4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/handle-empty-file-list

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@robaone robaone merged commit eff596b into main May 4, 2026
1 check passed
@robaone robaone deleted the fix/handle-empty-file-list branch May 4, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants