Use Addressable to heuristically parse invalid URLs and normalize them#603
Merged
chvp merged 1 commit intorobbevp:mainfrom Jan 27, 2025
Merged
Use Addressable to heuristically parse invalid URLs and normalize them#603chvp merged 1 commit intorobbevp:mainfrom
chvp merged 1 commit intorobbevp:mainfrom
Conversation
chvp
force-pushed
the
fix/invalid-urls
branch
from
d00ea8b to
c1edcf0
Compare
robbevp
approved these changes
Jan 27, 2025
Owner
robbevp
left a comment
robbevp
left a comment
There was a problem hiding this comment.
👍 Didn't know about addressable. I got some errors in sentry around url with unicode as well (from the background jobs)
chvp
force-pushed
the
fix/invalid-urls
branch
from
c1edcf0 to
b269d73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the rendering of two posts that were failing from my feeds. There is already an indirect dependency on addressable anyway.