Fix shapely imports; fix test_filter_non_polygons #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @robbievanleeuwen, I'll be happy to help get that fixed |
Owner
Author
|
Thanks @normanrichardson, appreciated! |
Contributor
|
Hi @robbievanleeuwen, I think #261 handles the changes to STRtree. Let me know if I've missed anything |
Update STRtree api to shapely 2.0
Owner
Author
|
Thanks @normanrichardson! @connorferster this is ready, let me know if you've got time for a quick review :) |
connorferster
approved these changes
Dec 30, 2022
Collaborator
|
Looks good to me! I like how the shapely API has been simplified to offer the most common objects and functions in the top-level namespace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors resulting from shapely version 2, closes #258
@normanrichardson it looks like the STRtree implementation has changed, see here. After a quick look I couldn't exactly figure out how ours is working. If you have time, would you be able to have a quick look at fixing this by creating a PR to this branch? If not I can dig a bit deeper in the new year and try to figure it out 😄