Skip to content

codiffmap todo list #4

@robbyblum

Description

@robbyblum
  1. Fix the stuff described in DiffMap/coDiffMap loading funcs: standardize/simplify/make compatible with nmrglue #7
  2. Maybe copy the function diffmap.get_phasecorr2D into the codiffmap file
  3. Decide on ndarray dimension order: nmrglue uses the standard of "direct dimension last," which is the opposite of what we were using in Igor, at least for 2D arrays. I think it's a good convention to use, because then you can keep the t# in order. This probably requires more work in codiffmap than diffmap.
  4. Add a "convert States into MRI" function: copy it over from diffmap once that version is written?
  5. Standardize the docstrings

3/25/20: Removing nested lists is done, I think!

These functions still output or input or otherwise assume nested lists:

  1. stagger_sample
  2. sparsify_staggered (assumes list input)
  3. peak_amplitudes

Also, get_interesting_columns_all2D no longer returns a list but its docstring says it does!

These functions still have incorrect slicing syntax (should be [a, b, c] instead of [a][b][c]):

  1. get_interesting_columns_all2D (implicit dimensions, which isn't quite the same thing, but should be modified, IMO)
  2. setup_and_run_codiffmap
  3. sparsify_staggered
  4. peak_amplitudes

Metadata

Metadata

Assignees

Labels

coDiffMappertains to coDiffMap

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions