You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maybe copy the function diffmap.get_phasecorr2D into the codiffmap file
Decide on ndarray dimension order: nmrglue uses the standard of "direct dimension last," which is the opposite of what we were using in Igor, at least for 2D arrays. I think it's a good convention to use, because then you can keep the t# in order. This probably requires more work in codiffmap than diffmap.
Add a "convert States into MRI" function: copy it over from diffmap once that version is written?
Standardize the docstrings
3/25/20: Removing nested lists is done, I think!
These functions still output or input or otherwise assume nested lists:
stagger_sample
sparsify_staggered (assumes list input)
peak_amplitudes
Also, get_interesting_columns_all2D no longer returns a list but its docstring says it does!
These functions still have incorrect slicing syntax (should be [a, b, c] instead of [a][b][c]):
get_interesting_columns_all2D (implicit dimensions, which isn't quite the same thing, but should be modified, IMO)
Maybe copy the functiondiffmap.get_phasecorr2Dinto the codiffmap filet#in order. This probably requires more work in codiffmap than diffmap.Add a "convert States into MRI" function: copy it over from diffmap once that version is written?3/25/20: Removing nested lists is done, I think!
These functions still output or input or otherwise assume nested lists:stagger_samplesparsify_staggered(assumes list input)peak_amplitudesAlso,get_interesting_columns_all2Dno longer returns a list but its docstring says it does!These functions still have incorrect slicing syntax (should be[a, b, c]instead of[a][b][c]):get_interesting_columns_all2D(implicit dimensions, which isn't quite the same thing, but should be modified, IMO)setup_and_run_codiffmapsparsify_staggeredpeak_amplitudes