Update LIFXMultiZone.groovy #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue where duration was not using seconds.
Contributor
Author
|
The duration for multizone lights (I do not own any other lifx lights so I'm not sure if this issue exists there) was always happening instantly regardless of what I set the duration to, in testing if I set the duration to 5000 it would take 5 seconds, it looks like this bit of the code was not accounting for the millisecond conversion. |
dkilgore90
suggested changes
Oct 27, 2020
LIFXMultiZone.groovy
Outdated
| off() | ||
| } else { | ||
| setZones('999:"[brightness: ' + level + ']"', duration) | ||
| setZones('999:"[brightness: ' + level + ']"', duration * 1000) |
Contributor
There was a problem hiding this comment.
I think you actually want this change at line 120, in setZones, so that the conversion from s to ms occurs for all calls.
ngaustad
commented
Oct 27, 2020
Contributor
Author
ngaustad
left a comment
ngaustad
left a comment
There was a problem hiding this comment.
Yes, my change worked for everything I was using it for but this is more complete.
dkilgore90
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where duration was not using seconds.