test: raise coverage and enforce global 90% thresholds (#219)

Add focused hook/component coverage tests and expand settings coverage for migration/shortcut branches. Switch Vitest coverage enforcement to global 90% across statements, branches, functions, and lines.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: robinebers

src/components/app/app-content.test.tsx

@@ -0,0 +1,105 @@
+import { fireEvent, render, screen } from "@testing-library/react"
+import { beforeEach, describe, expect, it, vi } from "vitest"
+
+const { overviewPageMock, providerDetailPageMock, settingsPageMock } = vi.hoisted(() => ({
+  overviewPageMock: vi.fn(),
+  settingsPageMock: vi.fn(),
+  providerDetailPageMock: vi.fn(),
+}))
+
+vi.mock("@/pages/overview", () => ({
+  OverviewPage: (props: unknown) => {
+    overviewPageMock(props)
+    return <div data-testid="overview-page" />
+  },
+}))
+
+vi.mock("@/pages/settings", () => ({
+  SettingsPage: (props: unknown) => {
+    settingsPageMock(props)
+    return <div data-testid="settings-page" />
+  },
+}))
+
+vi.mock("@/pages/provider-detail", () => ({
+  ProviderDetailPage: (props: { onRetry?: () => void }) => {
+    providerDetailPageMock(props)
+    return (
+      <div data-testid="provider-detail-page">
+        {props.onRetry ? <button onClick={props.onRetry}>retry-provider</button> : null}
+      </div>
+    )
+  },
+}))
+
+import { AppContent, type AppContentProps } from "@/components/app/app-content"
+import { useAppPreferencesStore } from "@/stores/app-preferences-store"
+import { useAppUiStore } from "@/stores/app-ui-store"
+
+function createProps(): AppContentProps {
+  return {
+    displayPlugins: [],
+    settingsPlugins: [],
+    selectedPlugin: {
+      meta: {
+        id: "codex",
+        name: "Codex",
+        iconUrl: "/codex.svg",
+        brandColor: "#000000",
+        lines: [],
+        primaryCandidates: [],
+      },
+      data: null,
+      loading: false,
+      error: null,
+      lastManualRefreshAt: null,
+    },
+    onRetryPlugin: vi.fn(),
+    onReorder: vi.fn(),
+    onToggle: vi.fn(),
+    onAutoUpdateIntervalChange: vi.fn(),
+    onThemeModeChange: vi.fn(),
+    onDisplayModeChange: vi.fn(),
+    onResetTimerDisplayModeChange: vi.fn(),
+    onResetTimerDisplayModeToggle: vi.fn(),
+    onGlobalShortcutChange: vi.fn(),
+    onStartOnLoginChange: vi.fn(),
+  }
+}
+
+describe("AppContent", () => {
+  beforeEach(() => {
+    overviewPageMock.mockReset()
+    settingsPageMock.mockReset()
+    providerDetailPageMock.mockReset()
+    useAppUiStore.getState().resetState()
+    useAppPreferencesStore.getState().resetState()
+  })
+
+  it("renders overview page for home view", () => {
+    useAppUiStore.getState().setActiveView("home")
+    render(<AppContent {...createProps()} />)
+
+    expect(screen.getByTestId("overview-page")).toBeInTheDocument()
+    expect(overviewPageMock).toHaveBeenCalledTimes(1)
+  })
+
+  it("renders settings page for settings view", () => {
+    useAppUiStore.getState().setActiveView("settings")
+    render(<AppContent {...createProps()} />)
+
+    expect(screen.getByTestId("settings-page")).toBeInTheDocument()
+    expect(settingsPageMock).toHaveBeenCalledTimes(1)
+  })
+
+  it("passes retry callback for provider detail view", () => {
+    const props = createProps()
+    useAppUiStore.getState().setActiveView("codex")
+    render(<AppContent {...props} />)
+
+    fireEvent.click(screen.getByRole("button", { name: "retry-provider" }))
+
+    expect(providerDetailPageMock).toHaveBeenCalledTimes(1)
+    expect(props.onRetryPlugin).toHaveBeenCalledWith("codex")
+  })
+})

src/hooks/app/use-panel.test.ts

@@ -0,0 +1,153 @@
+import { act, renderHook, waitFor } from "@testing-library/react"
+import { beforeEach, describe, expect, it, vi } from "vitest"
+
+const {
+  currentMonitorMock,
+  getCurrentWindowMock,
+  invokeMock,
+  isTauriMock,
+  listenMock,
+} = vi.hoisted(() => ({
+  invokeMock: vi.fn(),
+  isTauriMock: vi.fn(),
+  listenMock: vi.fn(),
+  getCurrentWindowMock: vi.fn(),
+  currentMonitorMock: vi.fn(),
+}))
+
+vi.mock("@tauri-apps/api/core", () => ({
+  invoke: invokeMock,
+  isTauri: isTauriMock,
+}))
+
+vi.mock("@tauri-apps/api/event", () => ({
+  listen: listenMock,
+}))
+
+vi.mock("@tauri-apps/api/window", () => ({
+  getCurrentWindow: getCurrentWindowMock,
+  currentMonitor: currentMonitorMock,
+  PhysicalSize: class PhysicalSize {
+    width: number
+    height: number
+
+    constructor(width: number, height: number) {
+      this.width = width
+      this.height = height
+    }
+  },
+}))
+
+import { usePanel } from "@/hooks/app/use-panel"
+
+describe("usePanel", () => {
+  beforeEach(() => {
+    invokeMock.mockReset()
+    isTauriMock.mockReset()
+    listenMock.mockReset()
+    getCurrentWindowMock.mockReset()
+    currentMonitorMock.mockReset()
+
+    isTauriMock.mockReturnValue(true)
+    invokeMock.mockResolvedValue(undefined)
+    currentMonitorMock.mockResolvedValue(null)
+    getCurrentWindowMock.mockReturnValue({ setSize: vi.fn().mockResolvedValue(undefined) })
+  })
+
+  it("handles tray show-about event", async () => {
+    const setShowAbout = vi.fn()
+    const callbacks = new Map<string, (event: { payload: unknown }) => void>()
+
+    listenMock.mockImplementation(async (event: string, callback: (event: { payload: unknown }) => void) => {
+      callbacks.set(event, callback)
+      return vi.fn()
+    })
+
+    renderHook(() =>
+      usePanel({
+        activeView: "home",
+        setActiveView: vi.fn(),
+        showAbout: false,
+        setShowAbout,
+        displayPlugins: [],
+      })
+    )
+
+    await waitFor(() => {
+      expect(listenMock).toHaveBeenCalledTimes(2)
+    })
+
+    act(() => {
+      callbacks.get("tray:show-about")?.({ payload: null })
+    })
+
+    expect(setShowAbout).toHaveBeenCalledWith(true)
+  })
+
+  it("cleans first listener if hook unmounts before setup resolves", async () => {
+    const unlistenNavigate = vi.fn()
+    let resolveNavigate: ((value: () => void) => void) | null = null
+
+    listenMock
+      .mockImplementationOnce(
+        () =>
+          new Promise((resolve) => {
+            resolveNavigate = resolve
+          })
+      )
+      .mockResolvedValue(vi.fn())
+
+    const { unmount } = renderHook(() =>
+      usePanel({
+        activeView: "home",
+        setActiveView: vi.fn(),
+        showAbout: false,
+        setShowAbout: vi.fn(),
+        displayPlugins: [],
+      })
+    )
+
+    unmount()
+    resolveNavigate?.(unlistenNavigate)
+
+    await waitFor(() => {
+      expect(unlistenNavigate).toHaveBeenCalledTimes(1)
+    })
+  })
+
+  it("cleans second listener if hook unmounts between listener registrations", async () => {
+    const unlistenNavigate = vi.fn()
+    const unlistenShowAbout = vi.fn()
+    let resolveShowAbout: ((value: () => void) => void) | null = null
+
+    listenMock
+      .mockResolvedValueOnce(unlistenNavigate)
+      .mockImplementationOnce(
+        () =>
+          new Promise((resolve) => {
+            resolveShowAbout = resolve
+          })
+      )
+
+    const { unmount } = renderHook(() =>
+      usePanel({
+        activeView: "home",
+        setActiveView: vi.fn(),
+        showAbout: false,
+        setShowAbout: vi.fn(),
+        displayPlugins: [],
+      })
+    )
+
+    await waitFor(() => {
+      expect(listenMock).toHaveBeenCalledTimes(2)
+    })
+
+    unmount()
+    resolveShowAbout?.(unlistenShowAbout)
+
+    await waitFor(() => {
+      expect(unlistenShowAbout).toHaveBeenCalledTimes(1)
+    })
+  })
+})