Skip to content

fix(amp): show credits in overview for credits-only users#263

Merged
davidarny merged 4 commits intomainfrom
fix/amp-credits-overview
Mar 4, 2026
Merged

fix(amp): show credits in overview for credits-only users#263
davidarny merged 4 commits intomainfrom
fix/amp-credits-overview

Conversation

@davidarny
Copy link
Collaborator

@davidarny davidarny commented Mar 4, 2026

Summary

  • Move Amp Credits line to overview scope so credits-only accounts show data on the overview card.
  • Add a regression test for Amp's current credits-only response text variant with the automatic top-up hint.
  • Update Amp provider docs to reflect the overview visibility behavior.

Screenshots

Before

CleanShot 2026-03-04 at 09 46 21@2x

After

CleanShot 2026-03-04 at 13 37 18@2x

Testing

  • bunx vitest run plugins/amp/plugin.test.js
  • bunx vitest run src/pages/overview.test.tsx
  • bun run test:coverage (fails on current main baseline too: branch coverage 89.61% vs threshold 90%)

@augmentcode
Copy link

augmentcode bot commented Mar 4, 2026

🤖 Augment PR Summary

Summary: Adjusts the Amp provider so the Credits metric shows on the overview card (including credits-only accounts).

Changes: Moves Credits to overview scope, adds a regression test for the credits-only “automatic top-up” display-text variant, and updates the Amp docs accordingly.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@davidarny
Copy link
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@davidarny
Copy link
Collaborator Author

augment review

@validatedev validatedev requested a review from Copilot March 4, 2026 11:00
Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Amp provider’s manifest so the Credits metric is visible on the Overview card for credits-only accounts, adds a regression test for a newer credits-only displayText variant, and updates provider documentation to match the new visibility behavior.

Changes:

  • Move Amp Credits line from detail to overview scope in the plugin manifest.
  • Add a test covering credits-only displayText that includes an automatic top-up hint suffix.
  • Update Amp provider docs to describe when Credits appears on the overview card.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
plugins/amp/plugin.test.js Adds a regression test for parsing credits-only text that includes the automatic top-up hint.
plugins/amp/plugin.json Moves the Credits line to overview scope so Overview filtering includes it.
docs/providers/amp.md Updates documentation to reflect that Credits is now an overview-visible line (including credits-only accounts).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@validatedev
Copy link
Collaborator

I was the one who implemented Amp. I thought I handled the credits thing correctly, but it seems I was wrong. Thank you 🥰

Copy link
Collaborator

@validatedev validatedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

Copy link
Owner

@robinebers robinebers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@davidarny davidarny merged commit 8b1a835 into main Mar 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants