Skip to content

Refactor downloader #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robinraju merged 2 commits into from
Jun 6, 2022
Merged

Refactor downloader #448

robinraju merged 2 commits into from
Jun 6, 2022

Conversation

@robinraju
Copy link
Owner

@robinraju robinraju commented Jun 6, 2022

Changes

  • Refactor downloader for better unit testing capability
  • Add HTTP mocking using nock to unit tests
  • Use BearerCredentialHandler from typed-rest-client instead for manually setting Auth token headers on requests to GH API.

@robinraju robinraju merged commit e0d2238 into main Jun 6, 2022
@robinraju robinraju deleted the refactor-downloader branch June 6, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Getting 400 on all downloads

2 participants

@robinraju