test(sam3): add tests for class_mapping feature in SAM3 v3 block#2202
Open
felipe-tomino wants to merge 1 commit intomainfrom
Open
test(sam3): add tests for class_mapping feature in SAM3 v3 block#2202felipe-tomino wants to merge 1 commit intomainfrom
felipe-tomino wants to merge 1 commit intomainfrom
Conversation
Adds block-level tests that exercise the full run() method with class_mapping (mocking run_locally), plus manifest validation tests. Refactored to match repo patterns: pytest fixtures, top-level functions, docstrings.
felipe-tomino
requested review from
PawelPeczek-Roboflow,
dkosowski87,
grzegorz-roboflow,
hansent,
probicheaux and
yeldarby
as code owners
Contributor
Author
|
This PR addresses this comment from @dkosowski87 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2196 — adds comprehensive tests for the
class_mappingfeature as requested in review.class_mapping)_apply_class_mappingunit tests (full, partial, no-match, multi-image, empty result, empty mapping)run()tests (mockingrun_locally, verifying class_mapping applied end-to-end)Test plan
pytest tests/workflows/unit_tests/core_steps/models/foundation/test_segment_anything3_v3.py -v