Add OTel spans to model artifact loading#2244
Merged
Conversation
…te source Adds child spans under the existing model.load span: - model.artifacts.load (source=local_cache) for cache hits - model.artifacts.download (source=s3 or roboflow_api) for remote downloads Each span carries model.id and model.artifacts.source attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds OpenTelemetry child spans inside the existing
model.loadspan to make model artifact loading observable. Previously,model.load_time_secondswas a single opaque measurement — it was impossible to tell whether the time was spent reading from local disk cache or downloading weights from a remote source.Three new spans are emitted, each carrying
model.idandmodel.artifacts.sourceattributes:model.artifacts.sourcemodel.artifacts.loadlocal_cachemodel.artifacts.downloads3model.artifacts.downloadroboflow_apiRelated Issue(s): N/A
Type of Change
Testing
Test details: Spans are emitted via the existing
start_spanhelper which degrades to a noop when OTel is not configured, so no existing behaviour changes.Checklist
Additional Context
model.load_time_secondson the parentmodel.loadspan is intentionally kept. It measures total model initialization time, which includes ONNX session creation and other setup beyond artifact fetching. The new child spans cover only the artifact portion, so the full picture looks like: