Fix download page to resolve latest release assets dynamically#2250
Merged
Fix download page to resolve latest release assets dynamically#2250
Conversation
The download page hardcoded asset filename patterns that no longer match the current releases: Windows installers now have a `-cpu` suffix (e.g. `inference-1.2.3-cpu-installer.exe`), and macOS `.dmg` builds are no longer published. Both links were 404ing. Fetch the latest release from the GitHub API and pick a matching asset by filename pattern instead. When no asset matches (e.g. no macOS build), show a fallback message and point the manual link at the releases page. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Erol444
requested review from
PawelPeczek-Roboflow,
dkosowski87,
grzegorz-roboflow,
hansent,
probicheaux and
yeldarby
as code owners
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The Windows/macOS install-page buttons also had hardcoded versioned asset URLs that 404 after the release naming changes. Point them at /download so the JS-driven resolver on that page handles OS-specific asset selection. Simplify the /download fallback copy to offer two clear alternatives (releases page or Docker install) in all failure modes: unknown OS, no matching asset, and API error. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
grzegorz-roboflow
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Already deployed (live): https://github.com/roboflow/inference/actions/runs/24728852816
Summary
-cpusuffix (e.g.inference-1.2.3-cpu-installer.exe) and macOS.dmgbuilds are no longer published. Both links were 404ing.*installer*.exefor Windows,*.dmgfor macOS) instead of building the URL from a templated version./releases/latestso users aren't dropped on a broken URL.Test plan
/downloadon Windows —.exeinstaller download starts for the latest release./downloadon macOS — fallback message shown, manual link goes to releases page (until a mac build is restored)./install/.🤖 Generated with Claude Code