perf(polygon-annotator): crop mask to bbox before findContours to reduce scan area#2275
Draft
perf(polygon-annotator): crop mask to bbox before findContours to reduce scan area#2275
Conversation
…uce scan area Instead of running mask_to_polygons on the full frame mask, crop to the detection bounding box first and offset the resulting polygon points back to full-frame coordinates. Adds a coordinate-correctness test that would catch a broken offset (existing tests used origin-aligned detections where the +[0,0] offset is a no-op). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2bbf36f to
7b84b73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perf(polygon-annotator): crop mask to bbox before findContours to reduce scan area
What does this PR do?
Instead of running mask_to_polygons on the full frame mask, crop to the detection bounding box first and offset the resulting polygon points back to full-frame coordinates. Adds a coordinate-correctness test that would catch a broken offset (existing tests used origin-aligned detections where the +[0,0] offset is a no-op).
Related Issue(s):
Type of Change
Testing
Test details:
I ran this code change on the pella edge devices and the masks drew as before. I also verified there was a significant speedup in the block.
Checklist
Additional Context