chore(logging): add codeql comments for sensitive data handling acros…#2327
Merged
Conversation
dkosowski87
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
hansent,
probicheaux,
rafel-roboflow and
yeldarby
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dkosowski87
force-pushed
the
code-scan-issues-cleanup
branch
from
0e3fbde to
8588b6d
Compare
dkosowski87
force-pushed
the
code-scan-issues-cleanup
branch
from
0946511 to
5fa95eb
Compare
…s multiple files - Added comments to indicate potential sensitive data handling in logging statements, including clear-text logging and hashing of API keys. - Updated logging messages in `webcam.py`, `configuration.py`, `core.py`, `base.py`, `sqlite_wrapper.py`, and test files to enhance clarity and security awareness.
…LiteWrapper - Added comments to indicate potential sensitive data handling in logging statements within the SQLiteWrapper class, ensuring clarity on the logging of column names without values.
… SQLiteWrapper - Revised comments in logging statements to clarify that only key names are logged, enhancing awareness of sensitive data handling practices.
- Renamed `_sqlite_row_columns_for_log` to `_sqlite_log` for improved clarity in logging column names. - Updated logging statements to use the new utility function, ensuring consistent handling of sensitive data in debug logs.
- Added formatting comments to clarify sensitive data handling in debug logs. - Ensured consistent logging practices across multiple exception handling scenarios in the SQLiteWrapper class.
- Eliminated formatting comments around logging statements in the SQLiteWrapper class to streamline the code. - Maintained clarity in logging practices while ensuring sensitive data handling is still appropriately addressed.
- Refactored logging statements in the SQLiteWrapper class to use f-strings for improved readability and consistency. - Ensured that sensitive data handling comments remain intact while enhancing the clarity of debug messages during exception handling.
- Enhanced the readability of debug logging statements in the SQLiteWrapper class by breaking long lines into multiple lines. - Maintained the integrity of sensitive data handling comments while improving the clarity of exception logging.
dkosowski87
force-pushed
the
code-scan-issues-cleanup
branch
from
deae40c to
391877f
Compare
- Updated the `_sqlite_log` function to use an `Iterable` for key retrieval, enhancing clarity in the logging of column names. - Maintained the focus on sensitive data handling while improving the structure of debug log outputs.
PawelPeczek-Roboflow
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
sqlite_wrapperthat given it might be broader we log only column keys instead