Nk/add volume support#2413
Merged
Merged
Conversation
nkuneman
requested review from
PawelPeczek-Roboflow,
dkosowski87,
grzegorz-roboflow,
hansent,
probicheaux,
rafel-roboflow and
yeldarby
as code owners
Adds a --volume / -v CLI flag to `inference server start` and a corresponding `volumes` parameter to `start_inference_container()`, allowing users to bind-mount host directories into the container.
nkuneman
force-pushed
the
nk/add-volume-support
branch
from
b820ea3 to
ce297a9
Compare
|
|
PawelPeczek-Roboflow
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding an option to bind mount a local volume to the inference server. This was only possible through running the docker run command manually prior to this. The option exists now for creating the inference server throug both the CLI and Python.
Related Issue(s):
Stems from a feature I wanted when building my demo project
Type of Change
Testing
Test details:
The tests verify that the hardcoded /tmp volume is always present in the container regardless of what the user passes, and that any user-supplied volumes are merged in alongside it correctly.
Checklist