Skip to content

Fix model_id bug with InferenceAggregator block#876

Merged
PawelPeczek-Roboflow merged 3 commits intomainfrom
fix-aggregator-init-params
Dec 12, 2024
Merged

Fix model_id bug with InferenceAggregator block#876
PawelPeczek-Roboflow merged 3 commits intomainfrom
fix-aggregator-init-params

Conversation

@robiscoding
Copy link
Contributor

Description

  • Changing model_id to a runtime param instead of init param since init was failing:
{
  "inner_error": "ModelMonitoringInferenceAggregatorBlockV1.__init__() missing 1 required positional argument: 'model_id'"
}

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

  • Updated tests
  • Tested on staging, example output:
[
  {
    "$inputs.image": {...},
    "$steps.model.inference_id": "075298ae-4810-402f-95cd-91677c866470",
    "$steps.model.predictions": {...},
    "$steps.model.model_id": "animals/1",
    "$steps.model_monitoring_inference_aggregator.error_status": false,
    "$steps.model_monitoring_inference_aggregator.message": "Data sent successfully",
    "$steps.bounding_box_visualization.image": {
      "type": "base64",
      "value": ""...
      "video_metadata": {...}
    }
  }
]

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@PawelPeczek-Roboflow PawelPeczek-Roboflow merged commit ea7dc65 into main Dec 12, 2024
84 checks passed
@PawelPeczek-Roboflow PawelPeczek-Roboflow deleted the fix-aggregator-init-params branch December 12, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants