Fix problems related to lack of trailing / at the end of model_path. #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoSaverioZuppichini
approved these changes
Jan 24, 2023
Contributor
FrancescoSaverioZuppichini
left a comment
FrancescoSaverioZuppichini
left a comment
There was a problem hiding this comment.
LGTM! 🚀
Thanks a lot @SkalskiP , please run make style to make the cli happy
Contributor
Author
Jacobsolawetz
deleted the
fix/proper_model_path_handling_in_model_deploy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our
.deploy()method currently works only ifmodel_pathis a string with/at the end. That results in unintuitive behavior. This PR makes the deployment work regardless of having/at the end or not.roboflow/notebooks#51 (comment)
Type of change
Please delete options that are not relevant.