environments and helmfiles not working together

[asychev]

Hi!

Maybe I'm doing something wrong, but this scenario not workinkg for me:

$ tree -L 2
.
├── app.yaml
├── charts
│   └── test
├── helmfile.yaml
└── values
    ├── app.gotmpl
    └── versions.yaml

3 directories, 4 files

helmfile.yaml:

environments:
  default:
    values:
      - values/versions.yaml

helmfiles:
  - app.yaml

app.yaml:

releases:
  - name: test
    chart: charts/test
    values:
      - values/app.gotmpl

values/app.gotmpl:

image:
  tag: "{{ .Environment.Values.version.app }}"

values/versions.yaml:

version:
  app: "1.12"

charts/test - just result of helm create test

The problem: helmfile template:

in ./helmfile.yaml: in .helmfiles[0]: in ./app.yaml: failed to render values files "values/app.gotmpl": failed to render [values/app.gotmpl], because of template: stringTemplate:2:22: executing "stringTemplate" at <.Environment.Values.version.app>: map has no entry for key "version"

What I'm doing wrong?

[asychev]

Example to reproduce: https://github.com/asychev/helmfile-issue-759

[asychev]

@mumoshu could you please take a look?

[mumoshu]

@asychev Hey! Helmfile doesn't inherit environment values to sub-helmfiles. That is,

You need this:

environments:
  default:
    values:
      - values/versions.yaml

in your app.yaml in order to make your values/app.gotmpl work as you might have expected.

[asychev]

@mumoshu what the reasoning behind it? Looks like it is natural to use environment values for complex environment assembled from multiple helmfiles

[mumoshu]

Because forcing all the values to be inherited reduces modularity of your sub-helmfiles. Inheritance is sometimes natural and sometimes not, which probably mean we need a option to enable/disable inheritance :)

We do support passing specific values down to sub-helmfiles as explained in #725

We've also discussed about an option to inherit all the values via valuesInherited: true #523 (comment). Would you mind opening a feature request for that if needed?

We do have a feature request to allow inheriting or even specifying #725

[asychev]

@mumoshu That's clear, thank you!