Fix terminology#35
Merged
Merged
Conversation
mumoshu
force-pushed
the
fix-terminology
branch
from
e9a8f74 to
e9ee733
Compare
sstarcher
suggested changes
Mar 2, 2018
| st, err := state.ReadFromFile(file) | ||
| if err != nil && strings.Contains(err.Error(), fmt.Sprintf("open %s:", DefaultHelmfile)) { | ||
| var fallbackErr error | ||
| st, fallbackErr = state.ReadFromFile(DeprecatedHelmfile) |
Contributor
There was a problem hiding this comment.
when falling back to the deprecated value should we log a message to tell them it's deprecated?
Collaborator
Author
There was a problem hiding this comment.
Good point! I believe so.
Collaborator
Author
There was a problem hiding this comment.
sstarcher
approved these changes
Mar 2, 2018
Collaborator
Author
|
@sstarcher Thanks for reviewing 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a backward compatible manner, so that (I believe) we could move the discussion made in #25 forward.
Possibly fixes #25