Fix branch filter showing no results due to limited fetch #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When branch filter was active, fetchJobs only fetched a limited number of recent jobs (e.g., 50). Since branch filtering is done client-side, if none of those jobs matched the filtered branch, the TUI showed 0 results even though matching jobs existed in the database. Fixes: - Fetch all jobs (limit=0) when branch filter is active - Trigger refetch when applying/clearing branch filter (shows loading indicator instead of "No jobs matching filters") - Disable pagination when branch filter is active Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
wesm
force-pushed
the
fix-branch-filter-fetch
branch
from
70f63a9 to
046af90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where branch filter in the TUI would show "no matching jobs" even when matching jobs existed in the database.
Root Cause
When branch filter was active,
fetchJobsonly fetched a limited number of recent jobs (e.g., 50). Since branch filtering is done client-side, if none of those 50 jobs matched the filtered branch, the TUI showed 0 results.Fix
limit=0) when branch filter is active, matching existing behavior for repo filter and hideAddressed modesTest plan
TestTUINavigateDownNoLoadMoreWhenBranchFilteredtest🤖 Generated with Claude Code