Add --unaddressed flag to fix command for batch fixing #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `roborev fix --unaddressed` to discover and fix all unaddressed completed jobs for the current repo, defaulting to the current branch. Use --branch to override or --all-branches to include all branches. Refactors ListJobs to use functional options (WithGitRef, WithBranch, WithAddressed) instead of variadic string args. Adds branch and addressed query params to the daemon API. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- TestFixCmdFlagValidation: validates all flag constraint errors - TestRunFixUnaddressed: tests discovery flow (no jobs, found jobs, branch filter passthrough, server error) - TestListJobsWithBranchAndAddressedFilters: storage-level filter tests - TestHandleListJobsAddressedFilter: API-level addressed/branch params Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Return error from os.Getwd() instead of silently falling back to all-branches behavior (#3420.1) - Track review/address call counts in unaddressed test to verify all discovered jobs are actually processed (#3421.2) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Default ordering for --unaddressed is now oldest first so fixes are applied chronologically. Use --newest-first to reverse this. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
Like a champ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds batch fixing of unaddressed reviews. Instead of manually looking up job IDs, you can now run:
Jobs are processed oldest first by default so fixes are applied chronologically.
What changed
CLI (
cmd/roborev/fix.go):--unaddressed,--branch,--all-branches,--newest-first--unaddressedis set, queries the daemon for all completed-but-unaddressed jobs scoped to the current repo and branch, then runs the normal fix flow on eachStorage (
internal/storage/jobs.go):ListJobsto use functional options (WithGitRef,WithBranch,WithAddressed) instead of a variadic string parameter, making it easier to add new filtersDaemon API (
internal/daemon/server.go):/api/jobsnow acceptsbranchandaddressedquery parametersTest plan
go test ./...passes🤖 Generated with Claude Code