Feature fix list fixes available #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make truncateString operate on Unicode runes instead of bytes to avoid cutting multi-byte characters (emoji, non-ASCII text) - Add input validation for maxLen <= 0 - Fix os.Getwd() error handling in tests (was ignoring errors) - Remove duplicate JSON response branch in test mock handler - Add comprehensive test cases for truncateString edge cases including Unicode characters and zero/negative maxLen Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Check os.Chdir return errors in TestRunFixList subtests for consistency with the existing os.Getwd error handling - Clarify Unicode truncation test comment to explain that maxLen=5 results in 2 chars + "..." = 5 runes output Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
I don't get this:
Is there something here I have to fix? Why is it not green? |
Collaborator
I have to approve github actions runs from first-time contributors (I am going to tweak the settings, but I believe your PRs will run automatically afterward) |
Collaborator
|
firstLine was using byte-length checks and byte slicing which can split multi-byte UTF-8 characters. Reuse truncateString which already handles this correctly. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option that so that, before applying a fix, there is a list of the available fixes.