Conversation
Instead of erroring when --all-branches is used without --unaddressed, automatically set --unaddressed=true. Closes #344. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move the allBranches implication block before the --branch validation so that `fix --all-branches --branch main` hits the mutual-exclusion error instead of a confusing "--branch requires --unaddressed" message. Also add a positive test for `fix --all-branches` alone and update the --all-branches+--branch test to drop the explicit --unaddressed flag. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roborev fix --all-branchesnow implies--unaddressedinstead of erroring, removing an unnecessary sharp edge--all-branches --branch maincorrectly returns the mutual-exclusion error--all-branchesalone and updated existing flag-validation testsCloses #344
Test plan
TestFixCmdFlagValidationpasses (all error cases)TestFixAllBranchesImpliesUnaddressedpasses (positive case with mock daemon)TestFix*suite passes🤖 Generated with Claude Code