Add cursor agent support, reject unknown agents, fix ACP alias collision

[wesm]

Summary

• Add cursor agent with "agent" CLI binary and "agent" → "cursor" alias
• Reject unknown agent names (typos like --agent claud) with a clear error listing known agents, instead of silently falling back to a different agent
• Fix ACP alias collision where acp.name = "agent" would incorrectly intercept cursor requests via alias resolution — isConfiguredACPAgentName now uses exact matching on the raw (pre-alias) name
• Return 400 for unknown agent names and 503 for no-agents-available, using typed UnknownAgentError so HTTP handlers can distinguish the two cases
• Add deterministic agent fallback/availability tests for both enqueue and fix endpoints, with proper registry and PATH isolation

🤖 Generated with Claude Code

[roborev-ci]

roborev: Combined Review (e55336c)

Verdict: The changes strengthen agent resolution and error handling, but introduce high-severity syntax and scripting errors in the test
files that will break the build.

High

Syntax Errors in fmt.Sprintf Format Strings

• Location: internal/daemon/server_ops_test.go, lines 918-924
• Problem: Syntax errors due to unescaped quotes in fmt. Sprintf format strings (e.g., " @"%s", "$ @"n). This will prevent the test file from compiling and appears to be an unintended templating or substitution artifact.
• Fix: Escape the quotes and correct the strings properly (e.g., "@"%s" %%*\r\ n" and "#!/bin/sh\nexec '%s' \"$ @"n").

Invalid Windows Batch Script

• Location: internal/daemon/server_ops_test.go, line 978
• Problem: The content variable is assigned " @ internal/prompt/analyze/complexity.txt /b 0\r\n", which is not a valid Windows batch script (likely another templating substitution error).
• Fix: Replace with a valid Windows batch exit command, such as "@exit /b 0\r\n".

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[wesm]

"Invalid. The file compiles cleanly and the test passes. The reviewer's agents are mangling Go escape sequences
when rendering the source — they interpret " and \n in the Go string literals as actual quotes and newlines,
then report the "unescaped" result as a syntax error. The actual strings on disk are correct:

• Line 919: fmt.Sprintf("@"%s" %%*\r\n", gitPath) — valid Go
• Line 924: fmt.Sprintf("#!/bin/sh\nexec '%s' "$@"\n", gitPath) — valid Go
• Line 978: content = "@EXIT /b 0\r\n" — valid batch command
  "

Not sure what is up with github actions, I'll see if it comes back on later

[roborev-ci]

roborev: Combined Review (5c15163)

Verdict: The PR introduces valuable agent resolution improvements and
error handling refinements, but contains high-severity syntax errors in the newly added tests that will break compilation.

🔴 High

• internal/daemon/server_ops_test.go (in TestHandleFixJobAgentAvailability)
  • Problem: Syntax errors in fmt .Sprintf calls due to unescaped quotes and invalid escape sequences (" @"%s" %%*\r\n" and "#!/bin/sh\nexec '%s' \"$ @"n"). This prevents compilation.
  • Fix: Correct the string literals with proper escaping.
• **
  internal/daemon/server_ops_test.go** (in TestHandleFixJobAgentAvailability)
  • Problem: Accidental clipboard paste of a file path in the Windows mock script content (" @internal/prompt/analyze/complexity.txt /b 0\r\n" ).
  • Fix: Revert the mock script content back to a valid exit command (e.g., " @exit /b 0\r\n").

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (130f0e0)

Verdict: The PR introduces compilation errors and invalid mock script contents in test files that need to be addressed.

High

• internal/daemon/server_ops_test.go:918

  • Problem: Compilation error due to unescaped double quotes in the string literal fmt.Sprintf(" @"%s" %%*\r\n", gitPath).
  • Fix: Escape the quotes appropriately, e.g., fmt.Sprintf(" @\"%s\" %% *\r\n", gitPath).

• internal/daemon/server_ops_test.go:923

  • Problem: Compilation error due to mangled string literal and escape sequence fmt.Sprintf("#!/bin/sh\nexec '%s' \" $ @"n", gitPath).
  • Fix: Correct the arguments and newline to ensure valid Go syntax.

Medium

• internal/daemon/server_ops_test.go:977
  • Problem: The Windows mock script content accidentally includes a project file
    path instead of a batch command, likely due to IDE auto-complete (" @internal/prompt/analyze/complexity.txt /b 0\r\n").
  • Fix: Replace with a valid batch exit command, such as "@exit /b 0\r\n" .

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[wesm]

"No, same false positive as before. The review agents are interpreting Go escape sequences (", \n, $@) instead of
reading the raw source. The file compiles and passes on all platforms — I verified this earlier and the full go
test ./... suite passed."