Skip to content

build(deps): bump go-runewidth and glamour, update nix vendorHash#494

Merged
wesm merged 3 commits intomainfrom
dep-nix-update
Mar 10, 2026
Merged

build(deps): bump go-runewidth and glamour, update nix vendorHash#494
wesm merged 3 commits intomainfrom
dep-nix-update

Conversation

@wesm
Copy link
Copy Markdown
Collaborator

@wesm wesm commented Mar 10, 2026

Summary

Closes #489
Closes #490

🤖 Generated with Claude Code

dependabot bot and others added 3 commits March 10, 2026 07:39
Bumps [github.com/mattn/go-runewidth](https://github.com/mattn/go-runewidth) from 0.0.20 to 0.0.21.
- [Commits](mattn/go-runewidth@v0.0.20...v0.0.21)

---
updated-dependencies:
- dependency-name: github.com/mattn/go-runewidth
  dependency-version: 0.0.21
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/charmbracelet/glamour](https://github.com/charmbracelet/glamour) from 0.10.0 to 1.0.0.
- [Release notes](https://github.com/charmbracelet/glamour/releases)
- [Commits](charmbracelet/glamour@v0.10.0...v1.0.0)

---
updated-dependencies:
- dependency-name: github.com/charmbracelet/glamour
  dependency-version: 1.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@roborev-ci
Copy link
Copy Markdown

roborev-ci bot commented Mar 10, 2026

roborev: Combined Review (f238934)

Verdict: One High severity issue identified regarding a breaking API change in the glamour v1.0.0 update.

High

  • Files/Lines: go.mod:9, cmd/roborev/tui/helpers.go:10, cmd/roborev /tui/tui.go:16, internal/streamfmt/render.go:8, internal/streamfmt/streamfmt.go:12
    The glamour bump is a semver-major upgrade, but the code still imports github.com/charm bracelet/glamour/ansi. In glamour v1.0.0, that package is no longer present in the module, which will break module resolution during go build and go test.
    Suggested fix: Either pin glamour to v0.10. 0 for now, or update the renderer code to the v1.0.0 API/package layout and verify with a full go test ./... and go build ./... pass.

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@wesm
Copy link
Copy Markdown
Collaborator Author

wesm commented Mar 10, 2026

False positive. merging

@wesm wesm merged commit 25d26ff into main Mar 10, 2026
8 checks passed
@wesm wesm deleted the dep-nix-update branch March 10, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant