Fix NO_COLOR on TUI detail screens and add ROBOREV_COLOR_MODE env var

[strofimovsky]

Summary

• Fix NO_COLOR=1 not working on TUI review/prompt detail screens (glamour was ignoring it)
• Add ROBOREV_COLOR_MODE env var (auto|dark|light|none) for explicit TUI color theme control
• Apply color mode to both glamour (markdown) and lipgloss (AdaptiveColor) layers
• NO_COLOR takes precedence over ROBOREV_COLOR_MODE at all layers

Problem

glamour's NewTermRenderer defaults to TrueColor profile regardless of NO_COLOR. The main queue screen (lipgloss only) correctly respected NO_COLOR, but review/prompt detail screens (glamour-rendered markdown) always emitted ANSI color sequences.

Additionally, there was no way to force a dark/light theme when terminal background auto-detection failed.

Changes

Core fix

• Pass glamour.WithColorProfile() to all glamour.NewTermRenderer calls in both cmd/roborev/tui/helpers.go and internal/streamfmt/render.go
• Fix stripTrailingPadding/StripTrailingPadding to skip the \x1b[0m reset suffix in no-color mode

ROBOREV_COLOR_MODE env var

• auto (default): auto-detect terminal background
• dark: force dark color palette
• light: force light color palette
• none: strip all colors (same as NO_COLOR=1)

Lipgloss integration

• Call lipgloss.SetHasDarkBackground() / lipgloss.SetColorProfile() in TUI startup so AdaptiveColor styles on the queue screen also respect the env var
• Check NO_COLOR first to ensure it always takes precedence

Consolidation

• Remove duplicate resolveColorMode() from TUI helpers; delegate to streamfmt.GlamourStyle() + streamfmt.ResolveColorProfile()
• Update GlamourStyle() to check NO_COLOR (previously skipped, causing unnecessary terminal background queries)

Documentation

• Add ROBOREV_COLOR_MODE and NO_COLOR to README.md, AGENTS.md, and CLAUDE.md

Testing

• All existing tests pass (go test ./...)
• New tests: TestResolveColorProfile, TestRenderMarkdownLinesNoColor, TestGlamourStyleRespectsColorMode with proper dark/light style differentiation
• Manual testing confirmed: NO_COLOR=1, ROBOREV_COLOR_MODE=none, =dark, =light all work on both queue and detail screens

[roborev-ci]

roborev: Combined Review (46c262d)

Verdict: The PR introduces a high-severity security vulnerability allowing arbitrary local code execution
and a medium-severity TUI formatting bug.

High

• Location: internal/agent/acp.go#L1536, internal/config/config.go#L145
  Problem: opencode_cmd is a repo-loadable
  config value that directly overrides the executable path for the OpenCode agent. Because .roborev.toml is read from the repository and takes precedence over global config, a malicious/shared repo can point this field at a repo-controlled binary or script (e.g., ./tools/opencode), which will
  then be executed on the operator's machine when opencode is selected. This allows arbitrary local code execution via repository metadata.
  Fix: Do not honor executable-path overrides from repo config; restrict them to global config or CLI flags only. If repo-level support is strictly required, mandate explicit opt-in
  and validate that the path is absolute and rooted in a trusted user-controlled location.

Medium

• Location: cmd/roborev/tui/helpers.go:476, internal/streamfmt/render.go:91
  Problem: In NO _COLOR/ROBOREV_COLOR_MODE=none mode, these helpers stop re-appending \x1b[0m after trimming trailing SGR sequences. Glamour can still emit non-color formatting codes in termenv.Ascii mode (such as bold). Removing
  the trailing reset leaves styles open and can cause subsequent lines to render with leaked formatting.
  Fix: Always restore a reset after trimming, or fully strip remaining non-color SGR sequences when color is disabled.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (6251457)

Verdict: One medium severity finding regarding unclosed text formatting sequences when colors
are disabled.

Medium

• Location: cmd/roborev/tui/helpers.go:476, internal/streamfmt/render.go:91
• Problem: stripTrailingPadding/StripTrailingPadding omit the trailing reset when noColor is
  enabled, but Glamour still emits non-color SGR sequences (e.g., bold/underline) in termenv.Ascii mode. Removing the reset at the end of the line can leave attributes open, causing subsequent lines to inherit formatting unexpectedly under NO_COLOR / ROBO REV_COLOR_MODE=none.
• Fix: Keep the final reset even in no-color mode, or strip all remaining SGR sequences when noColor is enabled to prevent open formatting state from bleeding across lines.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[wesm]

Thanks for this, just pushed some roborev fixes. Will get this merged so I can release in the next hour or so

[roborev-ci]

roborev: Combined Review (27321fe)

Verdict: The proposed changes successfully introduce color mode support but contain a Medium severity issue regarding global state mutation.

Medium

• Location: cmd/roborev/tui/tui.go:531
  • Problem: newModel mutates Lip Gloss’s process-global default renderer with SetColorProfile / SetHasDarkBackground, but the
    auto path never restores those globals. If the process creates another TUI model after a prior dark, light, or none run, the later model can inherit a stale background or Ascii profile and render with the wrong theme or with colors still disabled.
  • Fix: Avoid
    mutating the package-global renderer, or explicitly recompute and reset both the color profile and dark-background state on every newModel call, including the auto case.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[wesm]

Not valid. Merging