fix(tui): allow j/k/q to be typed in filter search (#654)#655
Merged
Conversation
The filter modal bound j/k to navigate up/down and q to close, which swallowed those characters before they could reach the search input. The help text only advertises arrow keys and esc, so drop the vim-style aliases to match the documented UX. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
j/kto navigate up/down andqto close, which swallowed those characters before they could reach the search input (issue The "k" gets swallowed in filter modals (e.g. filter branch) #654).esc, so drop the vim-style aliases to match the documented UX.j/k/q; updated existing nav tests to use arrow keys.Closes #654
🤖 Generated with Claude Code