Fix robust logging and submodule issues for macOS#6
Conversation
This commit addresses a critical issue where the application would crash due to an UnauthorizedAccessException when attempting to create or write to a log directory. This was particularly problematic on macOS where the LocalApplicationData folder might return an inaccessible or invalid path in some environments. Changes: - Modified Program.cs to print global exceptions to Console.Error immediately, providing visibility even if logging fails. - Wrapped log file operations in Program.cs in a try-catch block to prevent secondary crashes. - Implemented robust log directory resolution with a fallback to Path.GetTempPath() if LocalApplicationData is unavailable. - Applied similar robustness improvements to MainWindow.LogException. - Updated agg-sharp submodule to macos-fixes branch and initialized recursive submodules (glfw-net) to ensure successful build and macOS compatibility. Co-authored-by: roboter <386485+roboter@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixed a runtime crash on macOS where the exception handler failed due to lack of permissions for the log directory. Also fixed build issues by updating submodules.
PR created automatically by Jules for task 1252973002679239414 started by @roboter