Separate core logic from SimpleXMLRPCServer implementation. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful to be able to implement a Robot Framework remote server that uses an external event loop (eg. Twisted). To do so, the RF remote interface should be integrated with that external event loop rather than just using SimpleXMLRPCServer. This change splits the existing RobotRemoteServer class into a server that manages the sockets, signals, starting, stopping, etc., and a new class RobotRemoteInterface that implements the logic of the XMLRPC API that can be reused with different event loops. This change should be transparent for all existing users.
Update test files to support split interface and server.
…ternally and then pass.
…ternally and then pass.
…ternally and then pass.
Author
|
I'm adding extra commits here as I try to get the test suite to run clean. I added Travis CI as a means of automating the testing, but it won't build cleanly yet (and argument_spec_invalid seems fairly intractable). |
Author
|
Also, I'm not happy with the location of the example Twisted remote server, but it didn't feel quite right putting it in the example/ directory either. Suggestions? |
Author
|
I'll resubmit this on a clean branch, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to be able to implement a Robot Framework remote server that
uses an external event loop (eg. Twisted). To do so, the RF remote interface
should be integrated with that external event loop rather than just using
SimpleXMLRPCServer.
This change splits the existing RobotRemoteServer class into a server that
manages the sockets, signals, starting, stopping, etc., and a new class
RobotRemoteInterface that implements the logic of the XMLRPC API that
can be reused with different event loops.
This change should be transparent for all existing users.