Skip to content

Webdriver factory 2#1039

Merged
aaltat merged 1 commit intorobotframework:masterfrom
aaltat:webdriver_factory_2
Feb 3, 2018
Merged

Webdriver factory 2#1039
aaltat merged 1 commit intorobotframework:masterfrom
aaltat:webdriver_factory_2

Conversation

@aaltat
Copy link
Copy Markdown
Contributor

@aaltat aaltat commented Jan 28, 2018

Fixes #550

@aaltat
Copy link
Copy Markdown
Contributor Author

aaltat commented Jan 28, 2018

Need to fix the problem with GeckoDriver.log which in this PR is created now in the folder where robot is started.

@aaltat
Copy link
Copy Markdown
Contributor Author

aaltat commented Jan 28, 2018

Also have to fix that unit test work with older versions of Selenium.

Moves the WebDriver creation to own class.
Also allows desired capabilites to be passes
also to the local browsers.

Fixes robotframework#550
@aaltat aaltat force-pushed the webdriver_factory_2 branch from e169ba2 to 4291c47 Compare February 3, 2018 20:43
@aaltat aaltat merged commit 172bac1 into robotframework:master Feb 3, 2018
@aaltat aaltat deleted the webdriver_factory_2 branch February 12, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants