added optional message param to the Title Should Be function#1044
Merged
aaltat merged 3 commits intorobotframework:masterfrom Feb 3, 2018
rubygeek:1042-add-message-page-title
Merged
added optional message param to the Title Should Be function#1044aaltat merged 3 commits intorobotframework:masterfrom rubygeek:1042-add-message-page-title
aaltat merged 3 commits intorobotframework:masterfrom
rubygeek:1042-add-message-page-title
Conversation
Contributor
|
We lately have had problems with Travis and it looks like you suffered from the same problem. I did restart the Travis jobs and let's see how it goes. |
Contributor
|
There was one tiny thing to add. Also if you want to have credit from your work, please add your name and what did you do in the https://github.com/robotframework/SeleniumLibrary/blob/master/CHANGES.rst |
Member
|
Thanks for PR! Docs should have a note that this is new in SL 3.1 (or whatever the version is). |
aaltat
approved these changes
Feb 3, 2018
| def title_should_be(self, title, message=None): | ||
| """Verifies that current page title equals ``title``. | ||
|
|
||
| The ``message`` argument can be used to override the default error |
Contributor
There was a problem hiding this comment.
Please add at the last line that message argument is new in SeleniumLibrary 3.1.
Contributor
|
Looking good, merged to master. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code and tests to complete #1042