Skip to content

Conversation

@Snooz82
Copy link
Member

@Snooz82 Snooz82 commented Jul 10, 2019

There are a few "Get" Keywords which return information about all windows of one browser. With this change it is also possible to get the window information of all windows of all browser.

Updated documentation about the relation of browsers and their windows.
Giving an example how to handle multiple browsers and multiple windows.

Cleanup:
Moving all keywords that where window related and not browser related from "BrowserManagementKeywords" to "WindowKeywords"

Snooz82 and others added 6 commits July 8, 2019 22:47
Added "browser" Option to all wondow Getters to get windows information of all browsers.
Created Browser/Window Documentation
Moved Window related Keywords from BrowsermanagementKeywords to WindowsKeywords
@Snooz82
Copy link
Member Author

Snooz82 commented Jul 10, 2019

fixes Issue: #1388

@Snooz82
Copy link
Member Author

Snooz82 commented Jul 10, 2019

@aaltat
i moved these Keywords from BrowserManagementKeywords to WindowKeywords:
If you want, i can undo this and move it to another Pull-Request.

def maximize_browser_window(self):
def get_window_size(self, inner=False):
def set_window_size(self, width, height, inner=False):
def get_window_position(self):
def set_window_position(self, x, y):
def get_source(self):
def get_title(self):
def get_location(self):
def location_should_be(self, url, message=None):
def location_should_contain(self, expected, message=None):
def log_location(self):
def log_source(self, loglevel='INFO'):
def log_title(self):
def title_should_be(self, title, message=None):
def go_back(self):
def go_to(self, url):
def reload_page(self):

@aaltat
Copy link
Contributor

aaltat commented Jul 14, 2019

I looked your code on mobile but I need to take a closer look with real PC.

But in mean time, I think moving keywords did break some of the unit tests. Could you take a look what did actually break and fix it?

Copy link
Contributor

@aaltat aaltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That bash enforcement is not needed. Please remove it.

Snooz82 and others added 2 commits July 15, 2019 22:20
…dling.

Modified dynamic_content.html to be able to manipulate the Window title freely.
@Snooz82
Copy link
Member Author

Snooz82 commented Jul 16, 2019

@aaltat i modified the dynamic_content.html to be able to set the window title with a free text. in local Tests it had no negative effects to other atests.

I think it is ready to be reviewed... ;-)

Copy link
Contributor

@aaltat aaltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not read all the code, but I have some questions first.

return open_driver_ids

@property
def active_aliases(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of wrapping like this, it would be good to change _alias as a public method. _alias -> alias

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But _aliases is a field of the Class ConnectionCache, which is part of robot.utils...
Do you wand me to make a pull request to this? This would brake a lot of libraries.
Also SSH Library uses _aliases etc...

May be i completely misunderstood.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know that, no need to change.

@Snooz82
Copy link
Member Author

Snooz82 commented Jul 28, 2019

That bash enforcement is not needed. Please remove it.
removed...

@aaltat
Copy link
Contributor

aaltat commented Aug 1, 2019

There is conflict that must be resolved before this can be merged.

@aaltat aaltat closed this Aug 1, 2019
@aaltat aaltat reopened this Aug 1, 2019
@aaltat
Copy link
Contributor

aaltat commented Aug 12, 2019

I made modifications to the documentation, so that it would be more easier to understand. I did went to a direction that hides most the Selenium and browser driver stuff, because it felt confusing. Now it talks about browser and windows (mostly.) Now I am bit scared that I did lost something when I did cut down the details, because for me it is clear but it makes me blind to some problems. Should we still change it someway to make it better?

@aaltat aaltat merged commit 3d049d5 into robotframework:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants