-
Notifications
You must be signed in to change notification settings - Fork 782
Modified Window Handling to be able to work over all active Browsers. #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ists of all browsers.
Added "browser" Option to all wondow Getters to get windows information of all browsers.
…as> are possible). Switches Browser before.
Created Browser/Window Documentation Moved Window related Keywords from BrowsermanagementKeywords to WindowsKeywords
|
fixes Issue: #1388 |
|
@aaltat def maximize_browser_window(self): |
|
I looked your code on mobile but I need to take a closer look with real PC. But in mean time, I think moving keywords did break some of the unit tests. Could you take a look what did actually break and fix it? |
aaltat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That bash enforcement is not needed. Please remove it.
…dling. Modified dynamic_content.html to be able to manipulate the Window title freely.
|
@aaltat i modified the dynamic_content.html to be able to set the window title with a free text. in local Tests it had no negative effects to other atests. I think it is ready to be reviewed... ;-) |
…Python 2.7 atests...
aaltat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not read all the code, but I have some questions first.
| return open_driver_ids | ||
|
|
||
| @property | ||
| def active_aliases(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of wrapping like this, it would be good to change _alias as a public method. _alias -> alias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But _aliases is a field of the Class ConnectionCache, which is part of robot.utils...
Do you wand me to make a pull request to this? This would brake a lot of libraries.
Also SSH Library uses _aliases etc...
May be i completely misunderstood.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know that, no need to change.
|
|
There is conflict that must be resolved before this can be merged. |
… Location using the Get Browser Ids Keyword
|
I made modifications to the documentation, so that it would be more easier to understand. I did went to a direction that hides most the Selenium and browser driver stuff, because it felt confusing. Now it talks about browser and windows (mostly.) Now I am bit scared that I did lost something when I did cut down the details, because for me it is clear but it makes me blind to some problems. Should we still change it someway to make it better? |
There are a few "Get" Keywords which return information about all windows of one browser. With this change it is also possible to get the window information of all windows of all browser.
Updated documentation about the relation of browsers and their windows.
Giving an example how to handle multiple browsers and multiple windows.
Cleanup:
Moving all keywords that where window related and not browser related from "BrowserManagementKeywords" to "WindowKeywords"