Skip to content

Register driver before EventFiringWebDriver is called #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2019
Merged

Register driver before EventFiringWebDriver is called #1429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
269ec4b
Register driver before EventFiringWebDriver is called
aaltat Aug 16, 2019
79b4e19
Added [Tags] NoGrid
aaltat Aug 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions atest/acceptance/2-event_firing_webdriver/MyListener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
from robot.api import logger
from robot.libraries.BuiltIn import BuiltIn
from selenium.webdriver.support.events import AbstractEventListener


class MyListener(AbstractEventListener):

def before_navigate_to(self, url, driver):
logger.info("Before navigate to %s" % url)
sl = BuiltIn().get_library_instance('SeleniumLibrary')
if sl.driver:
logger.info('Got driver also from SeleniumLibrary.')

def after_navigate_to(self, url, driver):
logger.info("After navigate to %s" % url)
Expand Down
7 changes: 5 additions & 2 deletions atest/acceptance/2-event_firing_webdriver/event_firing_webdriver.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,16 @@ Open Browser To Start Page
[Tags] NoGrid
[Documentation]
... LOG 1:12 DEBUG Wrapping driver to event_firing_webdriver.
... LOG 1:14 INFO Got driver also from SeleniumLibrary.
Open Browser ${FRONT PAGE} ${BROWSER} remote_url=${REMOTE_URL}
... desired_capabilities=${DESIRED_CAPABILITIES}

Event Firing Webdriver Go To (WebDriver)
[Tags] NoGrid
[Documentation]
... STARTS 1:2 Before navigate to
... STARTS 1:6 After navigate to
... LOG 1:2 INFO STARTS: Before navigate to
... LOG 1:3 INFO Got driver also from SeleniumLibrary.
... LOG 1:7 INFO STARTS: After navigate to
Go To ${ROOT}/forms/named_submit_buttons.html

Event Firing Webdriver Input Text (WebElement)
Expand Down
4 changes: 2 additions & 2 deletions src/SeleniumLibrary/keywords/browsermanagement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,15 +249,15 @@ def _make_new_browser(self, url, browser='firefox', alias=None,
ff_profile_dir, remote_url,
options, service_log_path)
driver = self._wrap_event_firing_webdriver(driver)
index = self.ctx.register_driver(driver, alias)
try:
driver.get(url)
except Exception:
self.ctx.register_driver(driver, alias)
self.debug("Opened browser with session id %s but failed "
"to open url '%s'." % (driver.session_id, url))
raise
self.debug('Opened browser with session id %s.' % driver.session_id)
return self.ctx.register_driver(driver, alias)
return index

@keyword
def create_webdriver(self, driver_name, alias=None, kwargs={},
Expand Down